MontoyaTech/ignite-html
MontoyaTech/ignite-html
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Removed the on disconnected callback for elements since the only subscriber is the template and the template is already deconstructed by the element so there is no need to call it twice via the callback.

Browse Source
This commit is contained in:
Matt Mo 2021-01-06 08:51:24 -08:00
parent 5e276a0ddb
commit fb49e9ec35
2 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ignite-element.js
View File

@ -51,7 +51,6 @@ class IgniteElement extends HTMLElement {
super(); super();
this.elementConnected = false; this.elementConnected = false;
this.onDisconnected = null;
this.template = null; this.template = null;
this.elements = []; this.elements = [];
this.createProperties(); this.createProperties();
@ -247,12 +246,6 @@ class IgniteElement extends HTMLElement {
this.template.deconstruct(); this.template.deconstruct();
} }
//If we have a onDisconnected callback, call it and then remove the reference.
if (this.onDisconnected) {
this.onDisconnected();
this.onDisconnected = null;
}
//Detach the after render callback //Detach the after render callback
this.readyCallback.disconnect(); this.readyCallback.disconnect();

6
ignite-template.js
View File

@ -667,12 +667,6 @@ class IgniteTemplate {
this.element.template = this; this.element.template = this;
} }
//If the element has a onDisconnected function, attach to it
//(This way if a custom element is removed we can deconstruct and cleanup)
if (this.element.onDisconnected !== undefined) {
this.element.onDisconnected = () => this.deconstruct();
}
//Invoke any refs we have and pass back the element reference. //Invoke any refs we have and pass back the element reference.
this._refs.forEach((ref) => ref(this.element)); this._refs.forEach((ref) => ref(this.element));
} }