From 7ba146443fcf13fd92b0797dd5ee54a8031b6c1e Mon Sep 17 00:00:00 2001 From: MattMo Date: Tue, 31 Jan 2023 19:14:44 -0800 Subject: [PATCH] Fixed a bug with lists where elements would be in the wrong order in the DOM. --- ignite-template.js | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/ignite-template.js b/ignite-template.js index 1b72a6d..743376f 100644 --- a/ignite-template.js +++ b/ignite-template.js @@ -2278,11 +2278,7 @@ class list extends IgniteTemplate { items.forEach(item => { var template = this.forEachCallback(item, this.children.length); - if (this.elements.length > 0) { - template.construct(this.element.parentElement, this.elements[this.elements.length - 1].nextSibling); - } else { - template.construct(this.element.parentElement, this.element); - } + template.construct(this.element.parentElement, this.element); //If we are reflecting, attach to the elements disconnect event. if (this.reflecting) { @@ -2384,11 +2380,7 @@ class list extends IgniteTemplate { items.forEach(item => { var template = this.forEachCallback(item, start); - if (this.elements.length > 0) { - template.construct(this.element.parentElement, this.elements[start]); - } else { - template.construct(this.element.parentElement, this.element); - } + template.construct(this.element.parentElement, this.element); if (this.reflecting) { this.reflectCallbacks.splice(start, 0, template.element.attachOnDisconnect(disconnect => this.onItemRemove(item)));