From 31503e62d122776176024031d8987f0dca733e90 Mon Sep 17 00:00:00 2001
From: Matt Mo <matt@montoyatech.com>
Date: Wed, 22 Sep 2021 09:43:18 -0700
Subject: [PATCH] Added target attribute support. Ignite Object now supports
 setProperties. Added null check for props. Fixed some documentation wording.

---
 ignite-element.js  | 10 +++++++++-
 ignite-html.js     | 17 +++++++++++++++++
 ignite-template.js | 16 +++++++++++++---
 3 files changed, 39 insertions(+), 4 deletions(-)

diff --git a/ignite-element.js b/ignite-element.js
index e8f974b..efc56fa 100644
--- a/ignite-element.js
+++ b/ignite-element.js
@@ -180,7 +180,15 @@ class IgniteElement extends HTMLElement {
      * Sets all the property values on this element.
      */
     setProperties(props) {
-        if (props) {
+        if (props == null || props == undefined) {
+            return;
+        }
+
+        if (props instanceof IgniteObject) {
+            props.update();
+
+            Object.getOwnPropertyNames(props).forEach(name => this[name] = props[name]);
+        } else {
             Object.keys(props).forEach(name => this[name] = props[name]);
         }
     }
diff --git a/ignite-html.js b/ignite-html.js
index fcef1b6..dcb1f7c 100644
--- a/ignite-html.js
+++ b/ignite-html.js
@@ -402,6 +402,23 @@ class IgniteObject {
         });
     }
 
+    /**
+     * Sets the values of properties on this ignite object.
+     * @param {Object|IgniteObject} props The properties to set onto this ignite object. 
+     */
+    setProperties(props) {
+        if (props == null || props == undefined) {
+            return;
+        }
+
+        if (props instanceof IgniteObject) {
+            props.update();
+            Object.getOwnPropertyNames(props).forEach(name => this[name] = props[name]);
+        } else {
+            Object.keys(props).forEach(name => this[name] = props[name]);
+        }
+    }
+
     /**
      * Creates an IgniteObject or Array of IgniteObjects and returns it.
      * @param {Object|Array} obj The object to create an IgniteObject from. 
diff --git a/ignite-template.js b/ignite-template.js
index 3b76fd0..2e1511f 100644
--- a/ignite-template.js
+++ b/ignite-template.js
@@ -841,7 +841,7 @@ class IgniteTemplate {
     }
 
     /**
-     * Sets the value attribute of the element to be constructed by this template.
+     * Sets the src attribute of the element to be constructed by this template.
      * @param {String|IgniteProperty} value The value to set for the src attribute of the element to be constructed by this template.
      * @param {Function} converter An optional function that can convert the value if needed.
      * @returns This ignite template so function calls can be chained.
@@ -851,8 +851,8 @@ class IgniteTemplate {
     }
 
     /**
-     * Sets the value attribute of the element to be constructed by this template.
-     * @param {String|IgniteProeprty} value The value to set for the href attribute of the element to be constructed by this template. 
+     * Sets the href attribute of the element to be constructed by this template.
+     * @param {String|IgniteProperty} value The value to set for the href attribute of the element to be constructed by this template. 
      * @param {Function} converter An optional function that can convert the value if needed.
      * @returns This ignite template so function calls can be chained.
      */
@@ -860,6 +860,16 @@ class IgniteTemplate {
         return this.attribute("href", value, converter);
     }
 
+    /**
+     * Sets the target attribute of the element to be constructed by this template.
+     * @param {String|IgniteProperty} value The value to set for the target attribute of the element to be constructed by this template.
+     * @param {Function} converter An optional function that can convert the value if needed.
+     * @returns This ignite template so function calls can be chained.
+     */
+    target(value, converter = null) {
+        return this.attribute("target", value, converter);
+    }
+
     /**
      * Sets the name attribute of the element to be constructed by this template.
      * @param {String|IgniteProperty} value The value to set for the name attribute of the element to be constructed by this template.