MontoyaTech/ignite-html
MontoyaTech/ignite-html
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed a bug where getOldPropertyValues didn't check for the same instance of a property but rather their value. Added nav template. Fixed pagination so that the list can be null, though it's not ideal.

Browse Source
This commit is contained in:
MattMo 2023-04-15 08:27:11 -07:00
parent 485f8ae2bd
commit 1ccd66910c
2 changed files with 24 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ignite-html.js
View File

@ -384,7 +384,7 @@ Array.prototype.getPropertyValues = function () {
Array.prototype.getOldPropertyValues = function (property, oldValue) { Array.prototype.getOldPropertyValues = function (property, oldValue) {
var ret = []; var ret = [];
this.forEach(prop => { this.forEach(prop => {
if (prop == property) { if (prop === property) {
ret.push(oldValue); ret.push(oldValue);
} else { } else {
if (prop instanceof IgniteProperty) { if (prop instanceof IgniteProperty) {

25
ignite-template.js
View File

@ -1713,6 +1713,18 @@ class p extends IgniteTemplate {
} }
} }
/**
* An ignite template that can be used to construct a nav element.
*/
class nav extends IgniteTemplate {
/**
* @param {...String|Number|IgniteProperty|IgniteTemplate} children A series of children to be added to this template.
*/
constructor(...children) {
super("nav", children);
}
}
/** /**
* An ignite template that can be used to construct a ul element. * An ignite template that can be used to construct a ul element.
*/ */
@ -2658,7 +2670,11 @@ class pagination extends IgniteTemplate {
this.pages[this.currentPage].forEach(item => item.style.setProperty("display", "none", "important")); this.pages[this.currentPage].forEach(item => item.style.setProperty("display", "none", "important"));
//Recreate the pages. //Recreate the pages.
var pages = parseInt((this.list.length / this.pageSize)) + (this.list.length % this.pageSize > 0 ? 1 : 0); var pages = 0;
if (this.list) {
pages = parseInt((this.list.length / this.pageSize)) + (this.list.length % this.pageSize > 0 ? 1 : 0);
}
this.pages = []; this.pages = [];
for (var i = 0; i < pages; i++) { for (var i = 0; i < pages; i++) {
this.pages.push([]); this.pages.push([]);
@ -2715,7 +2731,11 @@ class pagination extends IgniteTemplate {
} }
//Init our pages to put elements into. //Init our pages to put elements into.
var pages = parseInt((this.list.length / this.pageSize)) + (this.list.length % this.pageSize > 0 ? 1 : 0); var pages = 0;
if (this.list) {
pages = parseInt((this.list.length / this.pageSize)) + (this.list.length % this.pageSize > 0 ? 1 : 0);
}
this.pages = []; this.pages = [];
for (var i = 0; i < pages; i++) { for (var i = 0; i < pages; i++) {
this.pages.push([]); this.pages.push([]);
@ -3033,6 +3053,7 @@ export {
small, small,
strong, strong,
i, i,
nav,
ul, ul,
li, li,
br, br,