MontoyaTech/Rest.Net
MontoyaTech/Rest.Net
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed a bug where a double empty constructor could be generated for a C# client if there is no fields/properties. Bumped package version to 1.7.3

Browse Source
This commit is contained in:
MattMo 2023-09-24 19:34:26 -07:00
parent 4c64f1c134
commit b9260dbdb1
2 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Rest.Net/Rest.Net.csproj
View File

@ -17,7 +17,7 @@
<AssemblyName>MontoyaTech.Rest.Net</AssemblyName> <AssemblyName>MontoyaTech.Rest.Net</AssemblyName>
<RootNamespace>MontoyaTech.Rest.Net</RootNamespace> <RootNamespace>MontoyaTech.Rest.Net</RootNamespace>
<GenerateDocumentationFile>True</GenerateDocumentationFile> <GenerateDocumentationFile>True</GenerateDocumentationFile>
<Version>1.7.2</Version> <Version>1.7.3</Version>
<PackageReleaseNotes></PackageReleaseNotes> <PackageReleaseNotes></PackageReleaseNotes>
<PackageIcon>Logo_Symbol_Black_Outline.png</PackageIcon> <PackageIcon>Logo_Symbol_Black_Outline.png</PackageIcon>
</PropertyGroup> </PropertyGroup>

19
Rest.Net/RestCSharpClientGenerator.cs
View File

@ -250,17 +250,20 @@ namespace MontoyaTech.Rest.Net
writer.Outdent().WriteLine('}'); writer.Outdent().WriteLine('}');
//Generate a constructor to set all the fields/properties with optional default values //Generate a constructor to set all the fields/properties with optional default values
writer.WriteBreak(); if (fields.Length > 0 || properties.Length > 0)
writer.Write($"public {(newName != null ? newName.Name : type.Name)}("); {
writer.WriteBreak();
writer.Write($"public {(newName != null ? newName.Name : type.Name)}(");
foreach (var field in fields) foreach (var field in fields)
writer.WriteSeparator().Write($"{this.GetTypeFullyResolvedName(field.FieldType)} {field.Name} = {this.GetTypeDefaultValue(field.FieldType)}"); writer.WriteSeparator().Write($"{this.GetTypeFullyResolvedName(field.FieldType)} {field.Name} = {this.GetTypeDefaultValue(field.FieldType)}");
foreach (var property in properties) foreach (var property in properties)
writer.WriteSeparator().Write($"{this.GetTypeFullyResolvedName(property.PropertyType)} {property.Name} = {this.GetTypeDefaultValue(property.PropertyType)}"); writer.WriteSeparator().Write($"{this.GetTypeFullyResolvedName(property.PropertyType)} {property.Name} = {this.GetTypeDefaultValue(property.PropertyType)}");
writer.WriteLine(")"); writer.WriteLine(")");
writer.WriteLine('{').Indent(); writer.WriteLine('{').Indent();
}
foreach (var field in fields) foreach (var field in fields)
writer.WriteLine($"this.{field.Name} = {field.Name};"); writer.WriteLine($"this.{field.Name} = {field.Name};");